Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect against command jailbreaking the executor container #353

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Protect against command jailbreaking the executor container #353

merged 2 commits into from
Aug 11, 2023

Conversation

BMurri
Copy link
Collaborator

@BMurri BMurri commented Aug 10, 2023

fixes #352

@BMurri BMurri requested a review from MattMcL4475 August 10, 2023 22:57
@BMurri
Copy link
Collaborator Author

BMurri commented Aug 11, 2023

Success: Passing in

  "image": "ubuntu:22.04",
  "command": [ "echo 'hello world'" ]

results in an exit code of 127 and the following systemlogs:

    "FailureExitCode",
    "Batch task ExitCode: 127, Failure message: The task exited with an exit code representing a failure",
    "Message: The task process exited with an unexpected exit code",
    "AdditionalErrorCode: FailureExitCode"

While passing in the "equivalent" "command": [ "echo", "hello world" ] results in the expected successful outcome.

@BMurri BMurri merged commit 5baf6c6 into main Aug 11, 2023
@BMurri BMurri deleted the bmurri/issue352 branch August 11, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattMcL4475 MattMcL4475 MattMcL4475 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command needs to be quoted to be scoped to run within the container
2 participants
@BMurri @MattMcL4475